wsg eth test finished #21
Conversation
test/v2/core/wsgETH.spec.js
Outdated
|
|
||
| const {r, s, v} = ethers.utils.splitSignature(signature); | ||
|
|
||
| // await expect(wsgEth.connect(alice).depositWithSignature(parseEther("1"), alice.address, deadline, false, v, r, s)) |
There was a problem hiding this comment.
does this not work as expected?
There was a problem hiding this comment.
Yeah. You can check this issue.
#19
I think this rate increasing by sgEth and wsgEth amount. but just deposit and withdraw keeps this rate to 1. How can I change this rate when test? |
|
@devlancer412 yep!
So for test, you could just admin mint some sgETH and send it to the wsgeth contract to test. See it in action in the rewards receiver here for e2e: https://github.com/chimera-defi/SharedDeposit/blob/main/contracts/v2/core/RewardsReceiver.sol#L32 |
|
So I need to deposit manually eth to RewardsReceiver contract to test sgEth/wsgEth rate change? |
|
@devlancer412 yep, exactly |
|
I couldn't test that because this error |
|
I finished test by avoiding top error. |
test/v2/core/wsgETH.spec.js
Outdated
| await sgEth.approve(wsgEth.address, parseEther("2")); | ||
| await wsgEth.deposit(parseEther("2"), alice.address); | ||
|
|
||
| console.log(formatEther(await wsgEth.pricePerShare())); |
There was a problem hiding this comment.
can we remove the left over console log
test/v2/core/wsgETH.spec.js
Outdated
| value: parseEther("1"), | ||
| }); | ||
| // sends 60% of sgEth to WSGEth contract - so current rate is 1.5/2.1 | ||
| console.log(await rewardsReceiver.state()); |
test/v2/core/wsgETH.spec.js
Outdated
| // redeem will get 1.1 sgEth | ||
| await expect(wsgEth.connect(alice).redeem(parseEther("0.5"), alice.address, alice.address)) | ||
| .to.be.emit(wsgEth, "Withdraw") | ||
| .withArgs(alice.address, alice.address, alice.address, parseEther("0.7"), parseEther("0.5")); |
There was a problem hiding this comment.
are we checking the invariant? i.e. alice has the expected balance after withdraw?
im not sure how the 10% bonus is represented here, 0.5 -> 0.55 would be expected based on the comment
also are you sure you need to manually call syncRewards?
iirc it should be triggered on redeem.
There was a problem hiding this comment.
with my analysis, reward of n' epoch distributes to next round by linearly. To test easily, I should call this once.
There was a problem hiding this comment.
ah cool yea updated comment looks good
test/v2/core/wsgETH.spec.js
Outdated
| await expect(wsgEth.syncRewards()).to.be.revertedWith("SyncError()"); | ||
| // increase time by reward cycle | ||
| await time.increase(24 * 60 * 60); | ||
| await wsgEth.syncRewards(); |
There was a problem hiding this comment.
is this call necessary? it should be triggered when redeem/withdraw is called automatically. and its a error condition if it needs to be manually triggered instead.
There was a problem hiding this comment.
actually syncRewards calls when user call another functions such as deposit and withdraw/redeem.
so actually not sure this function is called on time. But I should call this function to test increment of reward
There was a problem hiding this comment.
it should work without the direct call. when the user calls another function
or try to call the following again after sync rewards:
// deposit to rewardReceiver to simulate reward
await deployer.sendTransaction({
to: rewardsReceiver.address,
value: parseEther("1"),
});
// sends 60% of sgEth to WSGEth contract - so current rate is 1.5/2.1
await rewardsReceiver.work();
|
@chimera-defi Please check last updates |
No description provided.